IDEV-2272 and IDEV-2273: support header auth for iris endpoints and change default Feeds auth behavior #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Change default Feeds auth behavior
a.
always_sign_api_keyis False by default unless explicitly set by userb.
header_authenticationis True by default unless explicitly set by userc. Since RTTF endpoints don’t support signed API keys with any auth method, if the user sets
always_sign_api_key=Truefor RTTF, endpoints throw an error that says “Real Time Threat Feeds do not support signed API keys.”d. For non-RTTF endpoints,
always_sign_api_keyis set True unless explicitly set by userSupport X-Api-Key Header Auth for Iris Endpoints
Unit Tests:
E2E Tests:
